Repository navigation
Conversation
pass-set-global and pass-set-app ignored the helper result, so a failed save still showed "set" (or nothing at all) and the user believed future backups were encrypted. Show errMsg(r) and only update the state on ok. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting or clearing the global or per-app passphrase ignored the helper's result. A failed save still flipped the label to "set" (global) or showed nothing (per-app), so the user could believe later backups were encrypted when they weren't.
All four calls (
pass-set-globalset/clear,pass-set-appset/clear) now showerrMsg(r)whenokis false and only update the state label on success.Testing
node --checkon scripts.js.