Repository navigation
Conversation
Telegram stores one archive per app backup and telegram-pull restores only those. A folder or /data/adb backup to Telegram failed at upload time, after the local copy was written, and could not have been pulled back. Refuse it right after the destination is resolved with ERR_TG_KIND, and add the matching English message. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
Open
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend #10. A folder (path) or /data/adb backup to a Telegram destination always failed:
PKGis.paths/<name>or.adb/<ts>, so the packed file name"${PKG}__…vdb.tar"points into a missing subdirectory andtar -ffails withERR_TRANSFER, after the local backup was already written.Replacing the
/would make the upload work, buttelegram-pullonly knows app backups (<pkg>__<ts>_<vc>.vdb.tarinto<backups>/<pkg>/), so these uploads could not be restored. Until there is a pull path for.paths/.adb, this refuses them up front:do_path_backupanddo_adb_backup: right afterresolve_dest, a Telegram destination ends withERR_TG_KINDbefore any work is done.msg_err_tg_kindin en.js and en.json (same key); other languages fall back to English. The op card shows it througherrMsg.Not changed: the WebUI still lists Telegram destinations in the folder/adb destination pickers; hiding them there would be a separate UI change.
Testing
sh -n,mksh -n,busybox sh -n;shellcheck -s sh: same 96 warnings as main. en.json parses;node --checkon en.js.do_path_backupanddo_adb_backupwith stubbedresolve_dest/transport_guard/finish, under mksh R59, busybox 1.37 ash and dash: Telegram ends withERR_TG_KIND; rclone and local continue to the transport check.