Repository navigation
Conversation
The backup list started one backup-icon helper call per row on every
render (search keystroke, select toggle), and any failed call cached
"no icon" for that backup for good.
- New backup-icons helper verb: {refs:[...]} -> {ok, icons:{ref: b64
or ""}}, one process per batch.
- Backup icons load through iconObserver like app icons, in batches of
ICON_BATCH, with one in-flight request per ref.
- Only an answered ref is cached; "" caches as no icon, a failed call
is retried on a later render.
Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebUI #4.
renderBackupscalledloadBackupIconfor every row, and each one ranbackup-icon(one root process) with no batching, no lazy loading and no in-flight dedupe.renderBackupsruns again on every debounced search keystroke, select toggle and select-all, and the manager bridge serializes exec, so this queue blocked progress polling. Any failed call (includingERR_PARSE) cached"0"for that ref forever.backup-iconsverb,{refs:[...]}→{ok:true, icons:{<ref>: <b64 or "">}}.""means the manifest has no icon; invalid refs (sameref_rootcheck asbackup-icon) and refs without a manifest are left out.backup-iconstays. Documented in docs/AI-AGENTS.md.data-brefand are observed by the existingiconObserver;loadIconhands them toloadBackupIcon.renderBackupsunobserves its previous icons like the job/blocklist pickers do.loadBackupIconqueues refs andflushBackupIconssends them in batches ofICON_BATCH(same timer pattern asflushIcons). A ref already in flight is not requested again; icons from re-renders wait on the same request.""→"0"); a failed or partial answer leaves the rest uncached so they are retried later.Testing
node --checkon scripts.js;sh -n,mksh -n,busybox sh -non helper.sh;shellcheck -s sh: one more SC2016 note (jq$rin single quotes).backup-iconcalls.backup-icon, 3backup-iconscalls for the 38 rows that came into view; one ref the mock left out of the first answer was requested again once and then cached; no page errors. Same in Arabic (RTL).backup-iconsverb (helper.sh copy with the backups root pointed at a temp dir), under mksh, busybox ash and dash: icon and no-icon manifests answer"QUJD"and"";/etc/passwd, a..ref and a non-string are left out.