Repository navigation
Conversation
loadApps rebuilt the Excluded apps and Per-app items pickers on every app list load, so the full list was rendered three times on boot (and on every refresh or user switch) while the Settings tab was hidden. loadSettings already rebuilds both pickers when the tab opens; skip the build while it is not shown. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance.
loadAppscallsbuildBlockPicker()andbuildAppItemsPicker()after everylist-apps. Each picker builds one row per app inside the hidden Settings panel. So boot, the refresh button and a user switch render the whole app list three times, even though nobody sees the Settings rows.#settingsis the active panel (settingsShown()).loadSettings, which runs on every Settings tab open (switchTab sets.activefirst), still rebuilds both pickers from the currentAPPS. The save/clear handlers inside the per-app modal run with Settings shown, so they still rebuild.Testing
Playwright mock harness (shoot.py fixtures, 300 apps), en and ar:
loadApps()plus reopening Settings both have 300 again. No page errors.