Repository navigation
Conversation
The manager bridge runs one exec at a time, so call order is load order. Boot queued sanitize, dests-list, remote-list, pass-status, overview and list-ops ahead of list-apps, so the first screen waited behind calls only other tabs need. loadUsers/loadApps now return their promise; the other boot calls are queued once the app list request has settled. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance. The manager exec bridge runs one call at a time (see the comment above
deferredUpdateCheck), so the order calls are queued in is the order things load. On boot,list-apps(the first screen) was queued 12th, behindsanitize, the VDLU reads,dests-list,remote-list,pass-status,list-users,overviewandlist-ops.loadUsers()andloadApps()return their promise (existing callers ignore the result).config-getand i18n, boot callsloadUsers()first.loadOverview,reattachOps,loadDests,loadSettings,recoverPendingAuth,deferredUpdateCheckandsanitizerun once the app list request has settled, whether it succeeded or failed.Boot call order (mock):
Trade-off: an op that was running when the WebUI opened gets its progress card back after the app list instead of before it.
Testing