Repository navigation
Conversation
A long press on a tab, button or tappable row started a text selection and the WebView callout menu, which is what makes the UI feel like a web page. Turn off user-select and the touch callout on controls and row labels, and set touch-action: manipulation on tappable elements. Text in notices, dialogs and the log stays selectable. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native feel. In the WebView, a long press on a bottom tab, a button or an app or backup row selects its text and can open the callout menu. That is the most visible "this is a web page" tell.
.tabs,.tab,.btn,.icon-btn,.segment,summary.section-head, and the.name/.pkglabels inside.row.tappablegetuser-select: noneand-webkit-touch-callout: none.button,.tab,.row.tappable,summaryand checkboxes gettouch-action: manipulation, so taps skip the double-tap-zoom wait. Pinch zoom stays.Testing
user-selectisnoneon the tab, the row button and the row name (autoon main),touch-actionon a tab ismanipulation, and the body is stillauto.