Repository navigation
Conversation
ConsentActivity is exported so root can start it, which means any app can start it too and pick the result path. Accept only a consent.* file directly in filesDir, which is what the WebUI passes. Fix the README example, which pointed at /data/adb (not writable by the app). Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
Open
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsentActivityis exported so root can start it witham start, which means any app can start it and choose theresultpath. It now accepts only aconsent.*file directly in the app'sfilesDir, which is what the WebUI already passes (/data/data/ru.vd171.vdbackup/files/consent.<ts>). Paths are compared aftercanonicalFile, so/data/datavs/data/user/0matches.Also fixes the README example, which pointed the result at
/data/adb(the app can't write there).Testing