Skip to content

snow-chibi --install-prefix fix - #1226

Closed
Retropikzel wants to merge 4 commits into
ashinn:masterfrom
Retropikzel:snow-chibi-install-prefix-fix-cleaned
Closed

Retropikzel wants to merge 4 commits into
ashinn:masterfrom
Retropikzel:snow-chibi-install-prefix-fix-cleaned

Conversation

@Retropikzel

Copy link
Copy Markdown
Contributor
  • .github/actions/snow-chibi-tests/action.yaml
    • Add tests to make sure installing to prefix works and is not skipped because library is installed "globally"
  • Makefile
  • lib/chibi/snow/commands.scm
    • Remove unused function get-install-library-dirs
    • Move handling of prefix from get-install-dirs into get-install-library-dir, in the former it was only in some implementations
    • Insted of long cond which would need to have every implementation anyway pass the impl to the get-install-library-dir
    • If unknown implementation is given just throw an error in get-install-dirs, previously some path was returned and libraries where installed somewhere

I think this simplifies the code a bit too. Previously when I added support for new implementations I did not notice that some added the --install-prefix if it was there and left handling of it out for most implementations. Now it is always added and in one place only, so the implementation specific code can concentrate on just implementation specific stuff.

* Fix snow-chibi --install-prefix
@Retropikzel

Copy link
Copy Markdown
Contributor Author

For some reason these changes seem to have make the macos-intel tests pass. I'm not sure why.

@Retropikzel

Copy link
Copy Markdown
Contributor Author

For some reasons the macos test seems to fail again. I'm not sure why.

Comment thread Makefile.libs
MANDIR ?= $(man1dir)

# allow snow to be configured separately
SNOWPREFIX ?= /usr/local

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we preserve this and default it to $(PREFIX) ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats much better actually. I'll change it to that.

@Retropikzel

Retropikzel commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor Author

I think previously (as in chibi code, not in my changes here) snow-module-directory variable was used always and it was set to /usr/local/share/snow. Now that we get it here same way as other implementations the behaviour changed so that the libraries where installed under /usr/local/share/chibi. When I added the share-dir to be looked for with share/snow instead of just share it breaks things.

Edit: No, I was wrong. (chibi snow install) library is generated during build and that contains the variable.

@Retropikzel

Copy link
Copy Markdown
Contributor Author

I think I'd rather start over from the main branch, this is getting too messy. Closing this pull request and I'll open a new one with cleaner code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants