Repository navigation
snow-chibi --install-prefix fix - #1226
Retropikzel wants to merge 4 commits into
Conversation
* Fix snow-chibi --install-prefix
|
For some reason these changes seem to have make the macos-intel tests pass. I'm not sure why. |
…prefix-fix-cleaned
|
For some reasons the macos test seems to fail again. I'm not sure why. |
| MANDIR ?= $(man1dir) | ||
|
|
||
| # allow snow to be configured separately | ||
| SNOWPREFIX ?= /usr/local |
There was a problem hiding this comment.
Can't we preserve this and default it to $(PREFIX) ?
There was a problem hiding this comment.
Thats much better actually. I'll change it to that.
|
I think previously (as in chibi code, not in my changes here) snow-module-directory variable was used always and it was set to Edit: No, I was wrong. (chibi snow install) library is generated during build and that contains the variable. |
|
I think I'd rather start over from the main branch, this is getting too messy. Closing this pull request and I'll open a new one with cleaner code. |
I think this simplifies the code a bit too. Previously when I added support for new implementations I did not notice that some added the --install-prefix if it was there and left handling of it out for most implementations. Now it is always added and in one place only, so the implementation specific code can concentrate on just implementation specific stuff.