Repository navigation
Conversation
…g, server_info) The MVP's core tool set (RFC 0001 §3/§9), with mysql-mcp-server's names and arguments: - list_tables(database) and describe_table(database, table) call the mysql_mcp tool pack; arguments are hex literals converted to utf8mb4, so they are never parsed as SQL and need no escaping in any sql_mode. - ping: SELECT 1 with the round-trip time; a failure is a result with success false, as in the Go server. - server_info: version, engine, version comment, current user and database, character set, collation, max_connections, as one object. run_query reads its argument with its length (no truncation at NUL). test-mcp-endpoint.sh: tools/list order, each tool, argument errors, and a table name with quotes and backslashes staying literal. 37 checks. Part of #256 (RFC 0001 Phase 5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 item from #256: the core tools for the MVP (RFC 0001 §3 lists them as
list_databases,list_tables,describe_table,run_query,ping,server_info).Change
The endpoint had
list_databasesandrun_query. This PR adds four tools, using mysql-mcp-server's names and argument names:list_tablesdatabaseCALL mysql_mcp.list_tables(...)describe_tabledatabase,tableCALL mysql_mcp.describe_table(...)pingSELECT 1, then replies{"success","latency_ms","message"}. As in Go, a failure is a result withsuccess: false, not a tool errorserver_infoSELECTof version, engine, version comment, current user and database, character set, collation andmax_connections, returned as one objectCONVERT(X'…' USING utf8mb4)). They're never parsed as SQL and need no escaping under anysql_mode,NO_BACKSLASH_ESCAPESincluded.run_querynow reads its argument with its length, so a NUL no longer truncates it.server_infodoesn't port the Go server's extra fields (uptime, health snapshot, guard settings). The docs say so.Tests
scripts/test-mcp-endpoint.shonmysql:26.10.0: 37 passed, 0 failed. New checks:tools/listreturns the six tools in order;server_inforeports the mapped account and 26.10;\\,',)and; SELECT 1; --stays a literal (empty result, no error).Docs: Tools section, CHANGELOG.
Independent of #257–#261.
Part of #256.
🤖 Generated with Claude Code