Repository navigation
TOOLS-135: Support proxy-independent remote Gateway serving - #165
Merged
Merged
Conversation
averycrespi
marked this pull request as ready for review
October 12, 2026 22:07
averycrespi
added this pull request to stack #170
October 13, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
TOOLS-135 is the first PR in the remote Gateway stack, targeting
mainfrom creation basef7e90963de2b740b5a22102874da706e12d6f421. It enables a generic operator-owned HTTPS reverse proxy without changing local-only defaults.Changes
--external-originfor non-loopback administration.Review Notes
Independent pre-publication review covered all 30 changed files and AC1–6 at
27b4a4d81a45db39125d2768543a974480d71f50: complete, no material findings or blocking evidence gaps. A focused independent confirmation also found no material findings in the test-only fixture-permission repair ata2c70776b2c85838ffea3bb28460a6b77be48f6f.Public Host is exact and port-sensitive;
--allowed-hostcannot add browser trust. The proxy must preserve Host/Origin, stripForwardedandX-Forwarded-*, disable buffering/caching, and never replay mutations. A wildcard listener conservatively reserves its outbound destination port; use a specific bind if that outbound port is needed.External OAuth callbacks, upstream private-network policy, container packaging and container CI qualification are later tickets. Docker is unavailable locally: no container or live Debian/provider qualification is claimed. No merge, deployment or registry publication is included.
Test Plan
Passed local checks (race/count-one, five-minute package bounds, command-local
umask 077):make -C agent-gateway verifygo -C agent-gateway test -race -tags=integration -count=1 -timeout=5mcoverage forinternal/httpboundary,internal/api,internal/mcpingress,internal/httppolicy,internal/remoteand CLI behavior; updated CLI help/contract snapshots independently reconfirmed.go -C agent-gateway test -race -tags=integration -count=1 -timeout=5m ./internal/composition -run '^TestOptionalHTTPProxyCompositionAndDynamicListenerExclusion$'go -C agent-gateway test -race -tags=e2e -count=1 -timeout=5m ./test/e2e -run '^TestGatewayRemoteWildcardServingAndLocalCLI$'make -C agent-gateway test-harness, andnpm run format:checkThe initial CI fixture failure (temporary directory mode 0755 instead of required 0700) was reproduced and repaired without changing production permission checks. The HTTPS regression passes under both
umask 022andumask 002;make -C agent-gateway verifyalso passes after the repair.All 16 selected checks, including Required, pass on exact head
a2c70776b2c85838ffea3bb28460a6b77be48f6f: CI run 38313114362. This includes Linux/macOS integration and harness coverage, E2E, frontend browser, demo runners and the blocking vulnerability scan. Full outgoing history and exact PR metadata pass secret scanning.