Conversation
The POST /v0/server/backup endpoint, the bencher server backup CLI subcommand, and the database.data_store server config section are gone. Continuous replication under plus.disaster_recovery is the supported path, so bencher_schema no longer depends on the AWS SDK. A config that still carries database.data_store is ignored.
epompeii
added this pull request to stack #1042
September 18, 2026 06:48
Contributor
|
Bencher Report| Project | Bencher |
| Branch | u/ep/s3-r2/server-backup |
| Testbed | intel-v1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| Adapter::Json | 📈 view plot 🚷 view threshold | 5.24 µs(+8.35%)Baseline: 4.83 µs | 5.86 µs (89.44%) |
| Adapter::Magic (JSON) | 📈 view plot 🚷 view threshold | 5.03 µs(+7.50%)Baseline: 4.68 µs | 5.57 µs (90.32%) |
| Adapter::Magic (Rust) | 📈 view plot 🚷 view threshold | 28.33 µs(+7.46%)Baseline: 26.37 µs | 29.69 µs (95.42%) |
| Adapter::Rust | 📈 view plot 🚷 view threshold | 4.68 µs(+21.52%)Baseline: 3.85 µs | 5.95 µs (78.70%) |
| Adapter::RustBench | 📈 view plot 🚷 view threshold | 4.68 µs(+21.60%)Baseline: 3.85 µs | 5.93 µs (78.93%) |
epompeii
marked this pull request as ready for review
September 18, 2026 07:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The on demand database backup predates continuous replication and is unused. Its config section,
database.data_store, took an AWS S3 access point ARN and was the only reasonbencher_schemadepended on the AWS SDK. Continuous replication underplus.disaster_recoveryis the supported path.Changes
POST /v0/server/backupand its OPTIONS handler are removed, and the OpenAPI spec is regenerated.bencher server backupis removed from the CLI.database.data_storeand its types are removed from the server config;bencher_schemadropsaws-sdk-s3andaws-credential-types, and the root manifest dropsasync-compressionandrusqlite, which had no user left.data_store; the disaster recovery pages no longer refer to backups.Breaking changes
POST /v0/server/backupandbencher server backupare gone.database.data_storeis ignored. Remove the section.Second of a stack of three, on top of the
plus.disaster_recoveryrename. The last PR moves the container registry storage ontoobject_store, at which point the AWS SDK leaves the workspace.