Remove the on demand database backup and database.data_store

Cargo.toml

@@ -78,7 +78,6 @@ bencher_output_protocol = { path = "plus/bencher_output_protocol" }
 anyhow = "1.0"
 backhand = "0.25"
 assert_cmd = "2.2"
-async-compression = "0.4"
 async-stripe = { version = "1.0.0-rc.6", default-features = false }
 async-stripe-billing = "1.0.0-rc.6"
 async-stripe-checkout = "1.0.0-rc.6"
@@ -155,7 +154,6 @@ regex-lite = "0.1"
 reqwest = { version = "0.13", default-features = false }
 rmcp = { version = "2.2", default-features = false }
 rustls = { version = "0.23", default-features = false, features = ["aws_lc_rs"] }
-rusqlite = "0.38"
 rust_decimal = "1.40"
 # ECMAScript `Number::toString` formatting, which is what RFC 8785 (JCS) requires
 ryu-js = "1.0"

lib/api_server/src/lib.rs

@@ -6,7 +6,6 @@ use http as _;
 #[cfg(test)]
 use tokio as _;
 
-mod backup;
 mod config;
 mod root;
 mod spec;
@@ -36,13 +35,11 @@ impl bencher_endpoint::Registrar for Api {
             api_description.register(spec::server_spec_options)?;
             api_description.register(config::server_config_options)?;
             api_description.register(config::server_config_console_options)?;
-            api_description.register(backup::server_backup_options)?;
         }
         api_description.register(version::server_version_get)?;
         api_description.register(spec::server_spec_get)?;
         api_description.register(config::server_config_get)?;
         api_description.register(config::server_config_console_get)?;
-        api_description.register(backup::server_backup_post)?;
 
         #[cfg(feature = "plus")]
         {

lib/bencher_api_tests/src/context.rs

@@ -158,7 +158,6 @@ impl TestServer {
             public_pool,
             auth_pool,
             connection: Arc::new(Mutex::new(conn)),
-            data_store: None,
         };
 
         let request_body_max_bytes = max_body_size.map_or(DEFAULT_MAX_BODY_SIZE, |s| {
@@ -261,7 +260,6 @@ impl TestServer {
             public_pool,
             auth_pool,
             connection: Arc::new(Mutex::new(conn)),
-            data_store: None,
         };
 
         let _ = (upload_timeout, max_body_size);

lib/bencher_client/src/lib.rs

@@ -192,7 +192,6 @@ try_from_client!(
     JsonAccept,
     JsonAuthAck,
     JsonAuthUser,
-    JsonBackupCreated,
     JsonConfig,
     JsonConsole,
     JsonApiVersion,

lib/bencher_config/src/config_tx.rs

@@ -71,8 +71,6 @@ pub enum ConfigTxError {
     DatabaseConnection(String, diesel::ConnectionError),
     #[error("Failed to create database connection pool ({0}): {1}")]
     DatabaseConnectionPool(String, diesel::r2d2::PoolError),
-    #[error("Failed to parse data store: {0}")]
-    DataStore(bencher_schema::context::DataStoreError),
     #[error("Failed to register endpoint: {0}")]
     Register(dropshot::ApiDescriptionRegisterError),
     #[error("Failed to create server: {0}")]
@@ -257,19 +255,12 @@ async fn into_context(
     let public_pool = connection_pool(log, &database_path, busy_timeout)?;
     let auth_pool = connection_pool(log, &database_path, busy_timeout)?;
 
-    let data_store = if let Some(data_store) = json_database.data_store {
-        Some(data_store.try_into().map_err(ConfigTxError::DataStore)?)
-    } else {
-        None
-    };
-
     let database = Database {
         path: json_database.file,
         busy_timeout,
         public_pool,
         auth_pool,
         connection: Arc::new(tokio::sync::Mutex::new(database_connection)),
-        data_store,
     };
 
     info!(log, "Loading secret key");

lib/bencher_config/src/lib.rs

@@ -229,7 +229,6 @@ impl Default for Config {
             },
             database: JsonDatabase {
                 file: DEFAULT_DB_PATH.into(),
-                data_store: None,
                 busy_timeout: None,
                 cache_size: None,
             },

lib/bencher_json/src/lib.rs

@@ -116,7 +116,6 @@ pub use spec::{
 };
 pub use system::{
     auth::{JsonAccept, JsonAuthAck, JsonAuthUser, JsonConfirm, JsonLogin, JsonSignup},
-    backup::{JsonBackup, JsonBackupCreated},
     config::{JsonConfig, JsonConsole},
     spec::JsonOpenApiSpec,
     version::JsonApiVersion,