Add BootSnapshot for disk thumbnails, and a switch to skip audio synthesis - #23
Merged
Merged
Conversation
The extraSections line sat one column left of thumbnail, which scripts/format_all.sh --check reports. Whitespace only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hesis BootSnapshot boots a D88 headless (N88-BASIC V2, 4MHz, no Sound Board II, emulated-time RTC) and returns the frame to use as its thumbnail: it stops once the drives are quiet and the screen is stable, or animating without still filling up, and returns nil when the screen is nearly black or the machine is at the BASIC prompt. The Quick Look extension in the app uses it. PC88.audioOutputEnabled = false skips FM, SSG, rhythm and the mix while timers, busy status and ADPCM playback keep running, so the CPU sees no difference; a test checks the status ports, IRQ line and ADPCM EOS match. BootTester gains --snapshot to run the capture over disks and tune its thresholds, and BOOTTEST_AUDIO=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BootSnapshot: D88 をヘッドレスで起動し(V2・4MHz・サウンドボード II なし・エミュレート時間の RTC)、サムネイルに使う 1 フレームを返す。ディスクが止まり画面が落ち着いた時点で撮影し、ほぼ黒画面や BASIC の入力待ちならnilを返す。アプリ側の Quick Look 拡張(bubio/Bubilator88 の後続 PR)が使うPC88.audioOutputEnabled:falseで FM・SSG・リズム・ミックスを省略する。タイマー・busy・ADPCM の進行は続けるので、CPU から見える状態は変わらない--snapshot(停止条件の調整用)とBOOTTEST_AUDIO=0を追加SaveStateSerialize.swiftの継続行のインデント修正(空白のみ、別コミット)公開 API は追加のみで、既存の API・セーブステート形式・C ABI は変更していない。
Test plan
swift test(940 件 PASS)。音声スイッチの有無でステータス・IRQ・ADPCM EOS が一致するテストとBootSnapshotの判定テストを追加/regression(20 件 PASS)BootTester --snapshotでテスト用ディスク 18 枚を確認(タイトル 10 枚、期限打ち切りで妥当 3 枚、失敗扱い 4 枚、失敗画面 1 枚)scripts/format_all.sh --check指摘なし、scripts/lint.shで追加箇所に警告なし🤖 Generated with Claude Code