Conversation
commit: |
Collaborator
|
/bonk review this |
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Posted 1 inline finding. Review notes
|
Contributor
Docs PreviewCommit: |
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 544 files, 1.49 MB packed, 6.95 MB unpacked.
|
Contributor
Contributor
Visual Regression Report — 0 changed, 8 unchangedNo visual changes detected. |
2 of 5 tasks
Collaborator
|
Superseded by #818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In a few areas, the arrow in the Popover component would not animate in with the popover, but rather jump in after the fade/scale was done - which I believe to be unintended behaviour, for example in the 'before':
This fix makes it so
overflow-hiddendoesn't clip the arrow, and adds a motion wrapper, which permanently positions the arrow and does the zoom. The popup only fades, so its overflow can no longer clip the arrow