fix(popover): follow Base UI popup composition - #817
Merged
Merged
Conversation
Contributor
|
LGTM! Review notes
|
commit: |
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 544 files, 1.49 MB packed, 6.95 MB unpacked.
|
Contributor
Contributor
Visual Regression Report — 0 changed, 8 unchangedNo visual changes detected. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://codex-fix-popover-arrow-overflow-kumo-docs.design-engineering.workers.dev (commit 7733a9a)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
mattrothenberg
force-pushed
the
codex/fix-popover-arrow-overflow
branch
from
September 21, 2026 13:18
f72577a to
7733a9a
Compare
geoquant
approved these changes
Sep 21, 2026
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Positioner → Popup → Arrowstructureoverflow-autooroverflow-hiddendirectly toPopover.ContentPopover.Contentwhile the opening transition is activeThis is a compatibility-safe alternative to #814. Keep #814 open until this replacement is manually verified; once verified, this PR can supersede it.
Why opacity only
Some existing consumers use
Popover.Contentas their scroll container. A scale transform temporarily makes the popup the arrow's containing block, allowing popup overflow to clip the arrow during the transition. Opacity does not change containing-block behavior, so the arrow remains visible without changing existing consumer markup.A future breaking migration can introduce a dedicated nested scroll viewport and then restore scale animation.
Validation
pnpm --filter @cloudflare/kumo test:browser --run src/components/popover/popover.visual.browser.test.tsxpnpm --filter @cloudflare/kumo lintpnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo test --run(1,190 passed, 208 skipped)git diff --checkReviews
bonk has reviewed the change
automated review not possible because: compatibility behavior requires validation in a real browser
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: not applicable
Additional testing not necessary because: not applicable