feat(popover): add composable Base UI parts - #818
Merged
Merged
Conversation
Contributor
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Posted 2 inline findings with suggestions. Review notes
|
commit: |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://codex-base-ui-popover-parts-kumo-docs.design-engineering.workers.dev (commit 72cc3cf)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 544 files, 1.49 MB packed, 6.96 MB unpacked.
|
2 of 5 tasks
rozenmd
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Popover.Root,Portal,Backdrop,Positioner,Popup,Arrow, andViewportso Kumo mirrors Base UI's composition APIPopover.Contentas a deprecated, backwards-compatible wrapper with the opacity-only transition shipped in fix(popover): follow Base UI popup composition #817Popover.Popup, using Base UI's positioned transform origin--available-heightpopup sizing examplesWhy
#817 safely removed scaling from
Popover.Contentbecause downstream callers put overflow directly on that element. This follow-up makes the Base UI structure available without breaking those callers: new code can use the canonical parts and scale animation, while existingContentusages keep their safe fade-only behavior until they migrate.Validation
pnpm --filter @cloudflare/kumo lintpnpm --filter @cloudflare/kumo typecheckfocused Popover browser tests: 2/2 passing
pnpm --filter @cloudflare/kumo buildpnpm --filter @cloudflare/kumo-docs-astro typechecklocal docs verification at
/components/popover/Reviews
bonk has reviewed the change
automated review not possible because: review runs after the PR is opened
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows:
Additional testing not necessary because: