Repository navigation
[kumo] Fix tabs indicator entrance animation - #839
Closed
minwookshin wants to merge 1 commit into
Closed
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
2 of 5 tasks
Collaborator
|
I really appreciate the thoughtful work here. We’ve actually decided not to restore the entrance animation and will remove the unused styles in #841 instead. Closing in favor of that simpler approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #714.
Use
@starting-stylefor the indicator entrance and position it withleftso it scales around the selected tab. Disable the transition when reduced motion is requested.The four browser regressions failed before the fix and pass now; the same cases pass with reduced motion. Package build, typecheck, lint and 1,205 unit tests passed (208 skipped).