Skip to content

[kumo] Fix tabs indicator entrance animation - #839

Closed
minwookshin wants to merge 1 commit into
cloudflare:mainfrom
minwookshin:fix/tabs-indicator-entry-714
Closed

minwookshin wants to merge 1 commit into
cloudflare:mainfrom
minwookshin:fix/tabs-indicator-entry-714

Conversation

@minwookshin

Copy link
Copy Markdown

Fixes #714.

Use @starting-style for the indicator entrance and position it with left so it scales around the selected tab. Disable the transition when reduced motion is requested.

The four browser regressions failed before the fix and pass now; the same cases pass with reduced motion. Package build, typecheck, lint and 1,205 unit tests passed (208 skipped).


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: external contributor without access to the repository reviewer
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@mattrothenberg

Copy link
Copy Markdown
Collaborator

I really appreciate the thoughtful work here. We’ve actually decided not to restore the entrance animation and will remove the unused styles in #841 instead. Closing in favor of that simpler approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs: indicator pop-in animation never runs — data-[rendered=false] styles are dead against Base UI 1.6

2 participants