Repository navigation
[kumo] Remove unused Tabs entrance styles - #841
Merged
Merged
Conversation
Contributor
|
LGTM! Review notes
|
commit: |
Contributor
This was referenced Oct 5, 2026
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://codex-remove-tabs-entrance-animation-kumo-docs.design-engineering.workers.dev (commit a826bac)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 546 files, 1.50 MB packed, 6.94 MB unpacked.
|
nandanmen
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The removed selector targeted a
data-renderedattribute that Base UI's Tabs indicator does not emit, so the styles were unreachable. This is the smaller alternative to restoring a separate entrance animation in #839.Validation
vp lint src/components/tabsgit diff --checkReviews
bonk has reviewed the change
automated review not possible because: this is a one-line removal of an unreachable CSS selector
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: not applicable
Additional testing not necessary because: Base UI never emits the targeted attribute, so removing the selector does not change runtime behavior