fix(ed25519): set a minimum OS when compiling the C sources for Apple - #1623
Merged
Merged
Conversation
compileEd25519C_* ran `xcrun -sdk <sdk> clang -arch <arch> -O2 -c` with no -m*-version-min flag, so clang stamped each object with the SDK version as its minimum. In SharedCore 0.10.0 the nine ed25519 objects carry minos 18.5 (macOS 15.0) while the Kotlin/Native objects carry 14.0 (macOS 11.0). The iOS app and both notification extensions target 18.0, so each link emits one "built for newer 'iOS' version (18.5) than being linked (18.0)" warning per object: 21 in a cold iOS build. Pass the same minimums Kotlin/Native uses: iOS and simulator 14.0, macOS 11.0.
github-actions
Bot
added
area: crypto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compileEd25519C_*compiled the ed25519 C sources withxcrun -sdk <sdk> clang -arch <arch> -O2 -cand no minimum-version flag, so clang stamped each object with the SDK version as its minimum.In SharedCore 0.10.0 that leaves the nine ed25519 objects (
add_scalar,fe,ge,keypair,sc,sha3,sha512,sign,verify) at minos 18.5, and 15.0 on macOS, while the Kotlin/Native objects sit at 14.0 and 11.0. The iOS app and both notification extensions target 18.0, so every link emits oneld: warning: object file (…) was built for newer 'iOS' version (18.5) than being linked (18.0)per linked object. That's 21 warnings in a cold iOS build, 7 per target.This passes the same minimums Kotlin/Native already uses:
-mios-version-min=14.0,-mios-simulator-version-min=14.0and-mmacosx-version-min=11.0. After the change,vtool -show-buildreports 14.0 / 11.0 for every ed25519 object, and no object in a locally assembledSharedCore.xcframework(:kmp:shared-core:assembleSharedCoreReleaseXCFramework) is above 15.0.The iOS warnings go away once a
flipcash-shared-core-spmrelease built from this lands and iOS moves off 0.10.0.