Skip to content

fix(ed25519): set a minimum OS when compiling the C sources for Apple #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Sep 30, 2026
Merged

fix(ed25519): set a minimum OS when compiling the C sources for Apple #1623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions libs/encryption/ed25519/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,18 @@ val ed25519CSources = fileTree(ed25519SrcDir) {
//
// Output: build/cinterop/<targetName>/libored25519.a

data class AppleTarget(val kotlinName: String, val sdk: String, val arch: String)
// Without a -m*-version-min flag clang stamps each object with the SDK's own
// version as its minimum, and every app linking the framework with a lower
// deployment target gets one ld warning per object. These match the minimums
// Kotlin/Native stamps on the rest of the framework.
data class AppleTarget(val kotlinName: String, val sdk: String, val arch: String, val minVersionFlag: String)

val appleTargetDefs = listOf(
AppleTarget("iosArm64", "iphoneos", "arm64"),
AppleTarget("iosSimulatorArm64", "iphonesimulator", "arm64"),
AppleTarget("iosX64", "iphonesimulator", "x86_64"),
AppleTarget("macosArm64", "macosx", "arm64"),
AppleTarget("macosX64", "macosx", "x86_64"),
AppleTarget("iosArm64", "iphoneos", "arm64", "-mios-version-min=14.0"),
AppleTarget("iosSimulatorArm64", "iphonesimulator", "arm64", "-mios-simulator-version-min=14.0"),
AppleTarget("iosX64", "iphonesimulator", "x86_64", "-mios-simulator-version-min=14.0"),
AppleTarget("macosArm64", "macosx", "arm64", "-mmacosx-version-min=11.0"),
AppleTarget("macosX64", "macosx", "x86_64", "-mmacosx-version-min=11.0"),
)

appleTargetDefs.forEach { target ->
Expand All @@ -57,7 +61,7 @@ appleTargetDefs.forEach { target ->
commandLine("sh", "-c", buildString {
val compileLines = ed25519CSources.files.joinToString(" && ") { src ->
val obj = outDir.get().file(src.nameWithoutExtension + ".o").asFile.absolutePath
"xcrun -sdk ${target.sdk} clang -arch ${target.arch} -O2" +
"xcrun -sdk ${target.sdk} clang -arch ${target.arch} ${target.minVersionFlag} -O2" +
" -c \"${src.absolutePath}\"" +
" -I\"${ed25519SrcDir.absolutePath}\"" +
" -o \"$obj\""
Expand Down
Loading