feat(chat): adopt flipcash2 0.16.0 (private groups, bio, cover picture) - #1680
Merged
Merged
Conversation
…ver picture) Rename StartChatRequest.group to public_group and add the private_group start option. Wire the seven lobby and key-envelope chat RPCs and the SetBio and SetCoverPicture profile RPCs through service, repository and controller, with result-enum to domain-error mappings. Map is_private, in_lobby, bio, cover_picture and ChatUpdate.lobby_updates, and the new ENCRYPTION_REQUIRED send and edit results. KeyEnvelope is carried as opaque bytes; no key wrapping or CHAT_KEY encryption is implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the 0.16.0 contract in
:services:flipcash, with no UI:PublicGroupChatParameters, which the contract'sgroup→public_grouprename requires to compile. Adds a private-group option toStartChatParameters; nothing in the app creates one yet.EnterLobby,LeaveLobby,GetLobbyMembers,AdmitLobbyMember,DenyLobbyMember,SetKeyEnvelope,GetKeyEnvelope) throughChatApi→ChatService→ChatRepository→ChatController, each with its own sealed error.SetBioandSetCoverPicturethrough the profile stack; on success both write the result into the cached profile.ChatMetadata.isPrivate/inLobby,UserProfile.bio/coverPicture, andChatUpdate.lobbyUpdatesdecoded into a domainLobbyUpdate.EncryptionRequiredonSendMessageErrorandEditMessageError.KeyEnvelopetravels as opaque scheme/nonce/ciphertext. Wrapping and unwrapping the chat key, and sealing messages withCHAT_KEY_XCHACHA20POLY1305, is not here: it has to land on both platforms together. Until then a private group's messages can't be sent or read.Not handled yet: nothing reads
lobbyUpdatespast the domain model, and no send or edit caller handlesEncryptionRequired.