Repository navigation
feat(settings): open Settings from a gear on the You tab - #1689
Merged
Merged
Conversation
github-actions
Bot
added
type: feature
bmc08gt
added this pull request to stack #1696
October 7, 2026 01:28
Replaces AppRoute.Menu.MyAccount and AdvancedFeatures with a single AppRoute.Menu.Settings screen (Profile, Security, Privacy, Advanced, Account sections plus the version footer with tap-to-unlock). The features/advanced module is folded into features/myaccount and removed. EmailDeeplinkOrigin keeps its serialized "myaccount" value.
Drops the My Account row, the version footer and its tap-to-unlock from the You tab; the footer lives on Settings, which now also requests the debounced app update check the You-tab footer used to.
The route rename moved my_account_screen to settings_screen and Advanced's rows into Settings, so the flows now tap the gear on the You tab and assert settings_screen. unlock_beta_features taps the footer on Settings.
The Settings version footer scrolled under the gesture bar; the list now takes the navigation-bar inset as content padding. The You tab's gear moves from a floating overlay into the list, so it scrolls away with the page and the card keeps its resting offset. Also makes SettingsViewModel's OnBetaFeaturesUnlocked.manual explicit, asserts the already-a-developer toast in the tests, and drops unused menu module dependencies and drawables.
bmc08gt
force-pushed
the
feat/profile-refresh-settings
branch
from
October 7, 2026 01:56
7af6daa to
a7f7c38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of the profile refresh, matching code-payments/code-ios-app#985: a gear on the You tab opens one Settings screen that replaces My Account and Advanced Features.
Settings (
features/myaccount)Menu.UserProfilescreen, still gated on staff or beta access and now carrying the Beta badge, as on iOS.Routes
Menu.MyAccountis nowMenu.Settings.Menu.AdvancedFeaturesand thefeatures/advancedmodule are gone.EmailDeeplinkOrigin.MyAccountkeeps its serialized"myaccount"value, so verification links already in inboxes still parse and return to Settings.You tab
Maestro
subflows/navigate_to_settings.yaml), andunlock_beta_featurestaps the footer there.05_featureslost its Deposit Funds step, which pointed at a row Advanced no longer had.deposit.yamlcovers deposit.