Repository navigation
feat(chat): move Send Cash to the composer's right - #1006
Merged
Merged
Conversation
The round `$` now stands to the right of the message field instead of the left. When it shows is unchanged: Send Cash offered, not editing, draft empty, and it still springs out as the draft fills. Cancel-edit stays on the left. With nothing left of the field, the attach menu's leading reach is 0, and the placement test now expects the menu to start at the compact inset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The round
$now stands to the right of the message field instead of the left. When it shows is unchanged: Send Cash offered, not editing, draft empty, and it springs out as the draft fills while the send button takes over. Cancel-edit stays on the left.The glass layer behind the row moves the
$circle to the same side, so it still splits from and rejoins the field's glass. With nothing left of the field, the attach menu's leading reach is 0;AttachPanelPlacementTestsnow expects the menu to start at the compact inset.Android: code-payments/code-android-app#1702