Repository navigation
fix(chat): morph Send Cash out of the composer's glass - #1008
Merged
Merged
Conversation
The `$` split from the field read as two shapes overlapping. Each had its own 1pt rim stroke, and while the glass joined the strokes stayed apart, so a full circle outline sat inside the field and crossed it at the neck. - On iOS 26 `composerRim` draws nothing; the glass's own edge light follows the joined shape. The stroke stays for the material fallback. - The `$` glyph travels from the field's trailing edge with the bud, shows once the bud is out, and fades fast on the way back in. - `$` waits 0.1s for the send arrow to leave, and the arrow waits 0.16s for `$` to merge, instead of both crossfading in one spot. - Bounce drops from 0.3 to 0.12 so the overshoot doesn't touch the field again, and the glass joins within 8pt against the 10pt gap so no thread is left at rest.
bmc08gt
added a commit
to code-payments/code-android-app
that referenced
this pull request
Oct 7, 2026
#1702 put the send button inside the field's clip at the field's current edge, so typing showed it left of the $ and then slid it right as the field widened. It now appears at the $'s centre and overhangs the field's edge until the field catches up; the clip takes the overhang into account. Clearing still lets it ride the field's edge in. Timing follows code-payments/code-ios-app#1008: the $ shrinks to 0.4 toward the field's trailing edge, waits 0.1s before coming back, and fades on its own 0.12s ease-in and 0.1s ease-out. The send button waits 0.16s for the $ to merge, except while editing. The field spring keeps iOS's damping ratio (0.88) but uses stiffness 520 instead of 224. On iOS the glass merge makes the edge read as settled by about 200ms; Android has no glass merge, so at 224 the field visibly took the full ~300ms.
bmc08gt
added a commit
that referenced
this pull request
Oct 7, 2026
…cript-header-card * origin/main: fix(chat): morph Send Cash out of the composer's glass (#1008) fix(profile): open profiles from favorite groups and username search (#1011) fix(photos): set the accent color to blue so picker controls are readable (#1013) feat(profile): link a chat's token from its profile (#1010) # Conflicts: # Flipcash/Core/Navigation/AppRouter+Destination.swift # Flipcash/Core/Screens/Profile/ChatProfileScreen.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1006. The
$splitting from the message field read as two shapes overlapping rather than one piece of glass dividing.The main cause was the rim. The field and
$each drew their own 1ptcomposerRimstroke on the control, apart from the glass. While the glass joined into one shape, the strokes stayed separate, so a full circle outline sat inside the field and crossed it at the neck.composerRimdraws nothing, and Liquid Glass's own edge light follows the joined shape. The stroke stays for the material fallback before 26.$travels from the field's trailing edge with the bud, shows once the bud is out, and fades out in 0.1s on the way back in, so it is never seen inside the field.$waits 0.1s for the send arrow to shrink away, and the arrow waits 0.16s for$to merge (only when$is beside the field, not while editing). Before, both crossfaded in the same spot.$back into the field, and the container joins glass within 8pt against the 10pt resting gap, so no thread is left between them at rest.On iOS 26 the field also loses its rim at rest, not only during the morph.