Repository navigation
chore(protos): follow flipcash2 contract 3d6de707 (client 0.13.0) - #916
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on code-payments/flipcash2-client-protocol#19 (code-payments/flipcash2-client-protocol#19) merging and 0.13.0 being published. Until then the
exact: "0.13.0"requirement has no tag to resolve, so CI stays red.Follows the flipcash2 contract to
3d6de707:.dm,dmPayment/ChatMetadata.DmPaymentand.flipcardare updated in the proto mappings andChatPaymentMetadata.swift. The domainConversationType.tipDm,TipOrigin.tipcardandTipDmActionkeep their names.SpeakerRules.never: newConversationSpeakerRule.neverandConversationGateRequirement.never. It blocks speaking for everyone, staff included, andConversationGatePanelshows "Messages can't be sent in this chat".Content.widget: newShareProfileWidgetdomain struct. Widget messages are dropped inConversationMessage.initthe same way.mediaand.systemare, and a decrypted widget surfaces asDecryptFailure.unsupported. There is no placeholder bubble yet.SetDisplayNameResponse.username:ProfileServiceandFlipClient.setDisplayNamereturnUsername?.ProfileNameScreenandOnboardingNameViewModelstill ignore it.