Repository navigation
feat(chat): adopt flipcash2 0.16.0 (private groups, bio, cover picture) - #974
Merged
Merged
Conversation
bmc08gt
marked this pull request as ready for review
October 5, 2026 21:15
Add Conversation.description (in-memory), decode MetadataUpdate.DescriptionChanged into the store, and map DESCRIPTION_MODERATED on StartChat and EditChat results.
EditChat models unchanged, set, and clear explicitly via ConversationDescriptionEdit, since the wire tells them apart by whether the wrapper is set.
This was referenced Oct 5, 2026
bmc08gt
added a commit
that referenced
this pull request
Oct 5, 2026
Package.swift has pinned 0.17.0 since #974, but Package.resolved still named 0.16.0. Xcode Cloud resolves only from the committed file, so deploys fail at resolution until it matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins flipcash2-client-protocol 0.16.0 (code-payments/flipcash2-client-protocol#23), and
Package.resolvedresolves it ata5cc6f8a.Adopts the 0.16.0 contract in
FlipcashCore, with no UI:.group→.publicGroupinChatService.startChat, which the contract rename requires to compile. Nothing builds aprivate_groupstart yet.ChatService, withError*enums in proto order, and async wrappers inFlipClient+Chat(getLobbyMemberspages to the end).setBioandsetCoverPictureonProfileServiceandFlipClient+Profile.ProfilegainsbioandcoverPicture(reusingProfilePicture).Conversation.isPrivate/inLobby, in memory only. They aren't persisted, so a conversation restored from SQLite readsfalseuntil the server copy refreshes.ConversationStreamEvent.lobbyChanged, decoded fromlobby_updates. The store andConversationControllerignore it for now.encryptionRequiredonErrorSendMessage(3) andErrorEditMessage(6).EncryptedChatClientrefetches the conversation on it, the same asencryptionNotAllowed.KeyEnvelopetravels as opaque scheme/nonce/ciphertext. Wrapping and unwrapping the chat key, and sealing messages withCHAT_KEY_XCHACHA20POLY1305, is not here: it has to land on both platforms together.ChatSeal.openrejects the new scheme, so private-group messages show as unsupported until then.Only the last scaffolding commit compiles on its own; the rename lives there.