Repository navigation
fix(test): count concurrent fetches through a Sendable box - #979
Merged
Merged
Conversation
coalescesConcurrentFetches captured a local `Mutex` in `group.addTask` closures. `Mutex` is ~Copyable, so the closures capture it by reference and Swift 6 region-based isolation rejects the `sending` closure, which broke the test build in the "App vectors (build)" job. Hold the counter in a Sendable class instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Cross-platform vector gate" job "App vectors (build)" fails at test build on main:
coalescesConcurrentFetchescaptured a localMutex(0)in thegroup.addTaskclosures.Mutexis~Copyable, so the capture is by reference. The counter now lives in a privateSendableFetchCounterclass in the test file; the test still makes five concurrentcache.policycalls and expects one fetch. Production code is untouched.