fix(test): stop shadowing request() inside #require in ChatMediaViewerTests - #980
Merged
Merged
Conversation
…rTests `let request = try #require(request(...))` declares a local that the #require macro expansion resolves instead of the helper, so the test build failed with "cannot call value of non-function type 'ChatMediaViewerRequest'". Name the local viewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "App vectors (build)" job still fails after #979, now on
FlipcashTests/Chat/ChatMediaViewerTests.swift:48and:72:cannot call value of non-function type 'ChatMediaViewerRequest'. The UploadPolicyTests error stopped the build before it reached this file.let request = try #require(request(...))declares a local namedrequest, and the macro expansion resolvesrequest(...)to that local instead of the helper. The local is renamedviewer.