Skip to content

fix(test): stop shadowing request() inside #require in ChatMediaViewerTests #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Oct 6, 2026
Merged

fix(test): stop shadowing request() inside #require in ChatMediaViewerTests #980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions FlipcashTests/Chat/ChatMediaViewerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ struct ChatMediaViewerTests {

@Test("A viewable photo opens with its blob and URL")
func viewablePhotoOpens() throws {
let request = try #require(request(message(media())))
#expect(request.blobID == Self.blobID)
#expect(request.remote?.url == Self.remoteURL)
let viewer = try #require(request(message(media())))
#expect(viewer.blobID == Self.blobID)
#expect(viewer.remote?.url == Self.remoteURL)
}

@Test("A redacted photo, or one seen while previewing a group, never opens")
Expand All @@ -69,8 +69,8 @@ struct ChatMediaViewerTests {

@Test("A pending send opens on its staged image")
func pendingSendOpens() throws {
let request = try #require(request(message(media()), localImage: Self.localImage, remoteURL: nil))
#expect(request.localImage === Self.localImage)
let viewer = try #require(request(message(media()), localImage: Self.localImage, remoteURL: nil))
#expect(viewer.localImage === Self.localImage)
}

// MARK: - Viewer
Expand Down
Loading