Repository navigation
feat(profile): Edit Profile from the You tab, and the profile card reworked - #988
Merged
Merged
Conversation
This was referenced Oct 6, 2026
bmc08gt
force-pushed
the
feat/profile-refresh-other-profile
branch
from
October 6, 2026 20:12
c84475e to
16bc0a4
Compare
…rofile header The You tab's Edit Profile button now pushes Edit Profile instead of Settings, and Settings drops its interim Profile section. Edit Profile draws its cover with ProfileCoverBanner and its avatar at the You tab's 84pt with the same 5pt ring, so the two screens show the same empty cover. The parked CoverBanner, with its 3:1 card-colour fill, is removed; the cover editor previews a picked image through ProfileCoverBanner's new preview parameter. Row insets match Settings (25/20), values sit against the chevron, and the empty-cover plus uses appDisplayMedium instead of a 40pt system font.
…ards The cover sits in an inset card with a Change cover chip, the avatar overlaps its edge with a camera badge, and Name, Username, Bio and Minimum to Chat are label/value cards that open the existing editors.
A Medium-weight label reads as secondary next to the bold value.
iOS 18 keeps the opaque chip, since the row fill vanishes on a photo.
…tton The glass takes a backgroundMain tint so the label holds on a bright cover, and the chip is a button beside the cover card rather than a label inside it, so the interactive glass responds to its own press. Both open the cover editor.
…f the profile card Drop the link row and Share button; the profile's Share menu already offers both.
The card springs in from 0.55 scale with the bill pop's timing while the backdrop fades in, and Close plays it in reverse. The cover is presented and dismissed without its slide so the reveal is the only motion.
…glass swaps to Download in place The card was a full-screen cover with its own toolbar button laid over the You tab's gear. The two glass buttons sampled different backdrops, so the glass shifted and changed colour as the cover settled and cleared. The card is now an overlay in the You tab, the tab's one toolbar button swaps its glyph between Settings and Download, and the tab bar hides while it is up.
… from the You tab
The keyboard and Save button rose while the screen was still sliding in, so Save animated in from off screen. Name, Username, Bio, username lookup and group name now focus after the push finishes.
Edit Profile read only the account's own fee and showed "Not set" when there was none, while the You tab showed the regional minimum others actually pay. Both now use StartChattingFee.
bmc08gt
changed the base branch from
feat/profile-refresh-other-profile
to
main
October 6, 2026 20:12
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile-v2
branch
from
October 6, 2026 20:12
780c4d0 to
b52d8a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #987.
Edit Profile now opens from the You tab instead of Settings, and Settings loses its temporary Profile section. The layout follows Figma: an inset cover card with a Change cover button (Liquid Glass on iOS 26, the opaque chip on 18), the avatar with a camera badge, and Name, Username, Bio and Minimum to Chat as cards that open the existing editors.
FAILED_MODERATED, and saving it blank clears it.StartChattingFee, the same value as the You tab's stats card. It used to say "Not set" whenever you hadn't picked a fee, even though others were still charged the regional minimum.ProfileCoverBanner. The parked version's ownCoverBannerused a different aspect ratio and fill, so it's gone.The profile card got reworked here too. It's drawn inside the You tab rather than as a full-screen cover, so the toolbar's single glass button swaps its gear for Download in place. Two glass buttons stacked on each other were picking up different tints as the cover settled. Close moved to the bottom, the link row and Share button are gone (both are still in the Share menu), and the card springs in like a scanned bill and fades out at full size.
Name, Username, Bio, username lookup and group name now focus their field once the push lands, so Save doesn't ride the keyboard in from off screen.
Two commits belong to the Settings PR in spirit: uppercase section headings, and Account Info shown only with beta access, with the Beta badge.