Repository navigation
Conversation
'use std::f32;' (tests module) makes bare f32::EPSILON resolve to the deprecated module-path constant: hard clippy error on rustc 1.99 (-D warnings), blocking every pre-commit commit on current-stable machines while CI's floating stable toolchain still passes. Removing the import lets f32::EPSILON resolve to the associated constant (stable since 1.43) on old and new toolchains alike. Fixes #557
Collaborator
Author
|
Closing as redundant: the identical one-line fix (drop CI evidence for the contained change: #561 Clippy pass 2m50s on rustc stable (previously 4 errors on exactly these lines). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
use std::f32;import from thesrc/index/vector.rstests module so baref32::EPSILONresolves to the associated constant instead of the deprecated module-path constant.Why
On rustc 1.99
cargo clippy --all-targets -- -D warningsfails with 4deprecated constant std::f32::EPSILONerrors, which blocks every pre-commit commit on current-stable machines (the repo hook runs clippy). CI still passes only because its floatingrust-toolchain@stablelags behind. One-line, zero-behavior-change unblock; details in #557.Testing
cargo test --bin cora index::vector→ 14 passed, 0 failedcargo clippy --all-targets -- -D warnings→ clean (previously 4 errors)cargo fmt --all -- --check→ clean