All tools accept -h and --help by mernst · Pull Request #885 · codespecs/daikon

mernst · 2026-10-07T00:07:35Z

Tools that take no options other than -h/--help (SplitDtrace, ReadTrace, DtraceNonceFixer) now use DaikonGetopt, so they print usage for -h/--help and reject other options. Tools that use plume-lib Options (Chicory, DynComp, AnnotateNullable, BuildJDK) exit with status 0 after printing help.

New method DaikonGetopt.nonOptionArgs processes the arguments of such a tool. #887 adds the same method.

🤖 Generated with Claude Code

Add DaikonGetopt, a Getopt subclass that throws a UserError describing an unrecognized, ambiguous, or malformed option and handles -h and --help. Use it in Daikon and in the other tools that use Getopt. Remove Diff's -u and -z options, which had no effect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Tools that take no options other than -h and --help now use DaikonGetopt, so they print a usage message for -h and --help and reject other options. Tools that use plume-lib Options exit with status 0 after printing help. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-07T00:07:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: codespecs/daikon/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 9d94e169-a336-4859-88d3-42aa0a578a76

📥 Commits

Reviewing files that changed from the base of the PR and between 73f50a3 and 5b001be.

📒 Files selected for processing (12)

doc/CHANGELOG.md
doc/daikon.texinfo
java/daikon/AnnotateNullable.java
java/daikon/Chicory.java
java/daikon/DaikonGetopt.java
java/daikon/DynComp.java
java/daikon/SplitDtrace.java
java/daikon/dcomp/BuildJDK.java
java/daikon/dcomp/BuildJDK24.java
java/daikon/test/BadOptionTest.java
java/daikon/tools/DtraceNonceFixer.java
java/daikon/tools/ReadTrace.java

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Walkthrough

Several command-line tools now print usage and exit successfully when help is requested. DaikonGetopt adds shared processing for non-option arguments, which SplitDtrace, DtraceNonceFixer, and ReadTrace use. SplitDtrace adds argument and input validation. ReadTrace and SplitDtrace expose mainHelper methods for programmatic calls.

Suggested reviewers: markro49

Priority: ➖ Normal

Change: Feature

Merge Risk | ⚪ Minimal · up to 5b001

Merge Risk: ⚪ Minimal · up to 5b001

The CLI changes are ready to merge after normal checks; no introduced behavior requiring a fix was identified.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 5b001

The changed entrypoints stop help requests before file processing or target execution. The shared parser does not add privileges, and comparison with the previous behavior found no material security risk introduced or worsened by this change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The compared entrypoint changes retain the existing file-processing and target-launch authority. Newly public helpers expose the work previously reachable through public main methods; inspected callers do not establish a new privileged or remotely reachable execution path.

Trust Boundaries and Controls

observed — Help terminates before trace-file access, target launch, or JDK instrumentation. Non-help launcher requests retain their existing target checks, and both builders still require a destination before entering instrumentation paths.

Resilience and Maintainability Implications

observed — ReadTrace retains per-invocation ownership of its mutable file list, processor, program-point map, and sample storage. FileIO's global parsing state remains a pre-existing concurrency limitation; the helper extraction does not introduce it.

Pre-merge checks | 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage		Docstring coverage is 93.75% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 10 files. (2 skipped: 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

…menter argument errors on stderr, simplify ambiguity check

…-core

…option, report SplitterFactoryTest failures on stderr, shorten Diff error, align Annotate usage

… exiting, report instrumenter option errors in one line, make sentinels final

…enter -h to runtimechecker-options DaikonGetopt again provides nonOptionArgs, argsAfterLeadingOptions, a Supplier-based constructor, and setUsageHint, which codespecs#885-codespecs#888 use. The instrumenter's -h and --help handling belongs to codespecs#888.

…n-all-tools

…-option-core

…n-all-tools

…option-all-tools

… arguments in SampleTester and SplitterFactoryTest, fix --user-defined-invariant spelling

…-help

…Test main methods

mernst · 2026-10-11T18:34:01Z

@coderabbitai review

coderabbitai · 2026-10-11T18:34:09Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

# Conflicts: # doc/CHANGELOG.md

…-all-tools # Conflicts: # doc/CHANGELOG.md # java/daikon/test/BadOptionTest.java

mernst · 2026-10-12T08:16:55Z

@coderabbitai review

coderabbitai · 2026-10-12T08:17:02Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mernst and others added 2 commits October 6, 2026 17:06

mernst added 3 commits October 6, 2026 18:06

Remove stale comment in DtraceDiff

6380a6a

Merge branch 'bad-option-core' into help-option-all-tools

788e418

AnnotateNullable: print usage to stderr on error

056584e

This was referenced Oct 7, 2026

Fix runcluster.pl #856

Open

Exit with non-zero status on an unrecognized command-line option #857

Closed

mernst added 16 commits October 6, 2026 18:51

Address code review: reject "- " with no short options, report instru…

23bf08d

…menter argument errors on stderr, simplify ambiguity check

Merge remote-tracking branch 'origin/bad-option-core' into bad-option…

d20d9f8

…-core

Address code review: recognize -h in instrumenter, fix runcluster.pl …

0242d85

…option, report SplitterFactoryTest failures on stderr, shorten Diff error, align Annotate usage

Address code review: SplitterFactoryTest.mainHelper throws instead of…

9fc85fa

… exiting, report instrumenter option errors in one line, make sentinels final

Merge remote-tracking branch 'origin/bad-option-core' into help-optio…

62bf241

…n-all-tools

Merge branch 'master' of https://github.com/codespecs/daikon into bad…

e560e3e

…-option-core

Merge remote-tracking branch 'origin/bad-option-core' into help-optio…

2118b35

…n-all-tools

Move the runtimechecker changes to the runtimechecker-options branch

e8abacc

Merge branch 'bad-option-core' of github.com:mernst/daikon into help-…

335272a

…option-all-tools

Address code review: remove unused DaikonGetopt helpers, reject stray…

2b46b30

… arguments in SampleTester and SplitterFactoryTest, fix --user-defined-invariant spelling

Simplify DaikonGetopt: one constructor, which always handles -h and -…

50e3e2a

…-help

Move test-driver fixes and doc spelling fixes to separate pull requests

7df7f23

Handle DaikonTerminationException in SampleTester and SplitterFactory…

4f54694

…Test main methods

Brevity

117da2e

Merge branch 'master' into bad-option-core

3bee663

mernst added 3 commits October 11, 2026 17:58

Merge branch 'bad-option-core' into help-option-all-tools

68cc049

# Conflicts: # doc/CHANGELOG.md

Merge branch 'master' of github.com:codespecs/daikon into help-option…

3e5adec

…-all-tools # Conflicts: # doc/CHANGELOG.md # java/daikon/test/BadOptionTest.java

Add the DaikonGetopt helper that this pull request uses: nonOptionArgs

b1c773d

mernst mentioned this pull request Oct 12, 2026

CreateSpinfoC: report errors with a non-zero exit status #887

Merged

Report trace-reading errors in ReadTrace and SplitDtrace as user errors

5b001be

mernst merged commit cf78e73 into codespecs:master Oct 12, 2026
59 checks passed

mernst deleted the help-option-all-tools branch October 12, 2026 15:39

Navigation Menu

Repository navigation

All tools accept -h and --help - #885

All tools accept -h and --help#885
mernst merged 25 commits into
codespecs:masterfrom
mernst:help-option-all-tools

mernst commented Oct 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Walkthrough

Uh oh!

mernst commented Oct 11, 2026

Uh oh!

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

mernst commented Oct 12, 2026

Uh oh!

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mernst commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

mernst commented Oct 11, 2026

Uh oh!

coderabbitai Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mernst commented Oct 12, 2026

Uh oh!

coderabbitai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mernst commented Oct 7, 2026 •

edited

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading