Skip to content

Use the current spellings of --user-defined-invariant and --var-omit-pattern - #905

Merged
mernst merged 2 commits into
codespecs:masterfrom
mernst:option-doc-fixes
Oct 11, 2026
Merged

mernst merged 2 commits into
codespecs:masterfrom
mernst:option-doc-fixes

Conversation

@mernst

@mernst mernst commented Oct 11, 2026

Copy link
Copy Markdown
Member

The developer manual, a Javadoc comment, and two scripts used the old underscore spellings --user_defined_invariant and --var_omit_pattern. Daikon accepts only the hyphenated spellings, so runcluster.pl passed Daikon an unrecognized option.

Split out of #884.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: codespecs/daikon/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d1ca1d49-22a7-427d-96c4-f94bc8ad4eca

📥 Commits

Reviewing files that changed from the base of the PR and between 779e30d and d3fe680.


📒 Files selected for processing (5)
  • doc/developer.texinfo
  • java/daikon/Daikon.java
  • scripts/runcluster.pl
  • scripts/trace-purge-vars.pl
  • tests/daikon-tests/RatPoly/Makefile

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The developer manual and a Java field comment now use --user-defined-invariant. The runcluster invocation, a script comment, and a commented Makefile example now use --var-omit-pattern. The runcluster invocation also redirects stdout to the output file before redirecting stderr to stdout.


Priority: ➖ Normal

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d3fe6

The cluster invocation now uses Daikon’s documented option spelling and captures stderr with stdout; the other changes align references. No actionable merge risk is evident.

Pre-merge checks | Passed 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mernst

mernst commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mernst
mernst merged commit 36a38d7 into codespecs:master Oct 11, 2026
114 of 115 checks passed
@mernst
mernst deleted the option-doc-fixes branch October 11, 2026 17:51
@mernst

mernst commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants