Repository navigation
Conversation
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 3 minutes for your next included review. View limit details
Comment |
This was referenced Oct 11, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daikon.bashrcno longer infersJAVA_HOMEonly by resolving symlinks fromwhich javac, which is wrong for wrapper scripts such as those of jenv, asdf, or mise, and for the macOS/usr/bin/javacstub. It still follows symlinks first, because that is fast. If the result is not a JDK home (it lacks areleasefile),daikon.bashrcasks the javac on the PATH for itsjava.home. It handles JDK 8, whosejava.homeis thejre/subdirectory. This replaces the macOS-specific/usr/libexec/java_homecall.Daikon requires a JDK, not just a JRE, because it compiles splitters at run time. So
daikon.bashrcchecks that$JAVA_HOME/bin/javacis executable, rather than merely that the directory exists. The error message says whether a user-setJAVA_HOMEis not a JDK or no JDK could be found.A failed detection does not modify
JAVA_HOMEin the user's shell. Finding javac usestype -P, so aliases such asalias javac='javac -g'are ignored.