Repository navigation
macOS reader coordination, owner-channel security fix, and CI - #10
Merged
Merged
Conversation
…eparate from writer ownership, and let reader waits be cancelled.
…rrent test observations.
lucidprogrammer-svc
force-pushed
the
macos-reader-coordination-20261023
branch
from
October 23, 2026 15:09
d2c24ba to
b02c85a
Compare
lucidprogrammer
marked this pull request as ready for review
October 23, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted run: CI 39975873897 — green, 27 min 26 s (15:09:42 → 15:37:08 UTC), every job passed, including
lint-macos(7 min 41 s).Commits (on
dev6a0d4b4)69b3975aengine: verify macOS readers by process identity, keep reader holds separate from writer ownership, and let reader waits be cancelled.b02c85afci, tests: add macOS linting, regroup test bundles, and isolate concurrent test observations.What changed
Readers on macOS. A database reader is recognised by its verified process identity (process start plus the database file's identity), so a recycled process id or a replaced file cannot pass for a live reader. Reader holds are tracked apart from writer ownership, so a reader can never be mistaken for the writer or release its lock. A reader waiting for a release can be cancelled instead of blocking until the holder goes away.
macOS channel location (security fix). The default macOS owner channel used to sit at a predictable directory in the shared sticky
/tmp; any other local user could create it first and permanently deny the channel. It now lives in the per-user Darwin temporary directory, checked for ownership, mode 0700, no symlinks and a local filesystem, and fits the 104-byte socket-path limit. Linux is unchanged.CI. A macOS lint job is a required PR check; integration test bundles are regrouped by measured time; the aarch64 cross-compile uses a pinned, checksum-verified zig.
Tests. Tests that observed process-wide state use a thread-local recorder or isolated child processes. Tests that depended on timing now wait on real events: the purge-export test releases its pause on every path, the writer-flood trigger test holds its first callback until a contender actually reaches the contention point, and CLI pull progress is driven from page events. The crashed-holder PID-lock test (
tests/acceptance/db_lock_visibility.rs) is built on Linux only, on purpose.Cross-family review (Grok)
local_transport/runtime.rsstill named thecontextdbchild on macOS. Fixed in69b3975a(comment-only).Supersedes #9.