Repository navigation
Remove the Travis CI coverage leftovers - #184
Merged
danielpclark merged 1 commit intoOct 4, 2026
Merged
Conversation
The coverage block in test_helper only ran on Travis CI (`TRAVIS_OS_NAME`) with Ruby 2.4, so since the move to GitHub Actions and Ruby 2.5 to 2.7 it was dead code, and the `coveralls` gem it needed was still installed into every bundle. Nothing has reported coverage since 2018, so the Coveralls badge in the README no longer described this project. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CXvfgWzuq28ewqT3AyhX4Z
|
Review changes with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the move off Travis CI and AppVeyor (#103) by removing what was left of them in the code.
What
test/test_helper.rb: drops the SimpleCov/Coveralls block. It only ran whenTRAVIS_OS_NAMEwaslinuxand Ruby was 2.4, so on GitHub Actions with Ruby 2.5 to 2.7 it was dead code.Gemfile: drops thecoverallsgem (and the simplecov, thor, tins, term-ansicolor gems it pulled in) that everybundle installstill fetched for that dead code.README.md: removes the Coveralls badge. Nothing has reported coverage since 2018, and after this change nothing can, so the badge no longer described the project.Verification
With Ruby 2.7.8 on Linux, after regenerating
Gemfile.lock:rake sysinfostill prints the dependency list, andTEST_MONKEYPATCHES=true WITH_REGRESSION=true bundle exec rake minitest lintpasses (128 tests, 71 files inspected, no offenses).🤖 Generated with Claude Code
https://claude.ai/code/session_01CXvfgWzuq28ewqT3AyhX4Z
Generated by Claude Code