Skip to content

feat: Warn when installing or upgrading a deprecated plugin - #375

Merged
0xmc merged 2 commits into
mainfrom
feat/369-deprecation-install-upgrade
Nov 17, 2026
Merged

0xmc merged 2 commits into
mainfrom
feat/369-deprecation-install-upgrade

Conversation

@0xmc

@0xmc 0xmc commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Installing, restoring, or upgrading a deprecated plugin gave no warning, so people found out only when the plugin disappeared from its catalog.

These commands now print the deprecation notice after they succeed, including when an upgrade finds the plugin already current. A plugin that already moved to its replacement gets no notice.

Test plan

  • Install, restore, and upgrade of a deprecated catalog entry each print the notice on stderr and leave stdout unchanged
  • After adding the replacement's catalog under another name, the notice suggests installing from that name
  • After moving with an install from the replacement's catalog, upgrade prints no notice
  • Build, vet, and the plugin tests pass

Stacked on #374. Fixes #369

🤖 Generated with Claude Code

@0xmc 0xmc mentioned this pull request Nov 17, 2026
3 tasks done
@0xmc
0xmc force-pushed the feat/368-deprecation-notice branch from d68dbaa to 571d71b Compare November 17, 2026 17:47
Installing, restoring, or upgrading a deprecated plugin gave no
warning, so people found out only when the plugin disappeared from
its catalog.

install, restore (install with no arguments), and upgrade now print
the deprecation notice to stderr after the operation succeeds. The
operation itself still proceeds. upgrade prints it even when the
plugin is already current, since that is the command people run
routinely. The notice follows the catalog the plugin is recorded as
installed from, so a plugin that already moved to its replacement
gets no notice. Direct GitHub installs and failed upgrades get none.

The plugin system design doc describes what users see and how they
move to the replacement.

Resolves: #369

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0xmc
0xmc force-pushed the feat/369-deprecation-install-upgrade branch from 4a4b0ee to ceb677c Compare November 17, 2026 17:47
Base automatically changed from feat/368-deprecation-notice to main November 17, 2026 19:25
@0xmc
0xmc marked this pull request as ready for review November 17, 2026 19:54
@0xmc
0xmc requested a review from a team as a code owner November 17, 2026 19:54
@0xmc
0xmc enabled auto-merge November 17, 2026 19:54
@0xmc

0xmc commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Both reviewers returned merge on the first pass (head 4a4b0ee, base 8b1ca38).

pr-adversary: "VERDICT merge". It ran gh pr view; git diff 8b1ca38...4a4b0ee; gh pr checks; reads of install.go, upgrade.go and deprecation.go; go test ./internal/cmd/plugin/. It confirmed the notice is wired after success in installFromCatalog, installAllFromManifest (restore) and upgrade (including up to date), writes to stderr, and that moved plugins and direct GitHub installs get none. Its only open item was CI pending.

pr-conventions-reviewer: "VERDICT merge". It ran gh pr view; git diff; gh pr list for overlap; go build, go vet and go test. Its one nit, a 60-character commit subject (under the 72 hard limit), was not applied.

Since that pass the branch was rebased onto the squashed #374 (4a4b0ee to ceb677c). git range-diff reports the patch identical, so the reviewers were not re-run. GitHub's Update branch then added a merge-from-main commit, head 04ac57b. A final whole-branch review of the stack also covered this code. Earlier, a task-level review required a restore-path test and a docs flag fix, and both landed in the commit.

No findings beyond the nit were applied in this phase. CI on 04ac57b: ci / Build and test passed, license/cla passed. Auto-merge is enabled with the merge method, the only one the organization ruleset allows. The ruleset requires one code-owner approval on the last push, so the PR lands in front of a person. #376, #378 and #379 are stacked on this PR.

@0xmc
0xmc merged commit 701c41e into main Nov 17, 2026
2 checks passed
@0xmc
0xmc deleted the feat/369-deprecation-install-upgrade branch November 17, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install and upgrade give no warning for deprecated plugins

2 participants