Repository navigation
feat: Warn when installing or upgrading a deprecated plugin - #375
Conversation
d68dbaa to
571d71b
Compare
Installing, restoring, or upgrading a deprecated plugin gave no warning, so people found out only when the plugin disappeared from its catalog. install, restore (install with no arguments), and upgrade now print the deprecation notice to stderr after the operation succeeds. The operation itself still proceeds. upgrade prints it even when the plugin is already current, since that is the command people run routinely. The notice follows the catalog the plugin is recorded as installed from, so a plugin that already moved to its replacement gets no notice. Direct GitHub installs and failed upgrades get none. The plugin system design doc describes what users see and how they move to the replacement. Resolves: #369 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4a4b0ee to
ceb677c
Compare
|
Both reviewers returned merge on the first pass (head 4a4b0ee, base 8b1ca38). pr-adversary: "VERDICT merge". It ran gh pr view; git diff 8b1ca38...4a4b0ee; gh pr checks; reads of install.go, upgrade.go and deprecation.go; go test ./internal/cmd/plugin/. It confirmed the notice is wired after success in installFromCatalog, installAllFromManifest (restore) and upgrade (including up to date), writes to stderr, and that moved plugins and direct GitHub installs get none. Its only open item was CI pending. pr-conventions-reviewer: "VERDICT merge". It ran gh pr view; git diff; gh pr list for overlap; go build, go vet and go test. Its one nit, a 60-character commit subject (under the 72 hard limit), was not applied. Since that pass the branch was rebased onto the squashed #374 (4a4b0ee to ceb677c). git range-diff reports the patch identical, so the reviewers were not re-run. GitHub's Update branch then added a merge-from-main commit, head 04ac57b. A final whole-branch review of the stack also covered this code. Earlier, a task-level review required a restore-path test and a docs flag fix, and both landed in the commit. No findings beyond the nit were applied in this phase. CI on 04ac57b: ci / Build and test passed, license/cla passed. Auto-merge is enabled with the merge method, the only one the organization ruleset allows. The ruleset requires one code-owner approval on the last push, so the PR lands in front of a person. #376, #378 and #379 are stacked on this PR. |
Summary
Installing, restoring, or upgrading a deprecated plugin gave no warning, so people found out only when the plugin disappeared from its catalog.
These commands now print the deprecation notice after they succeed, including when an upgrade finds the plugin already current. A plugin that already moved to its replacement gets no notice.
Test plan
Stacked on #374. Fixes #369
🤖 Generated with Claude Code