Skip to content

feat: Show deprecated plugins in list, search, and browse - #378

Merged
0xmc merged 2 commits into
mainfrom
feat/371-deprecation-listings
Nov 18, 2026
Merged

0xmc merged 2 commits into
mainfrom
feat/371-deprecation-listings

Conversation

@0xmc

@0xmc 0xmc commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The plugin list, search, and browser showed a deprecated plugin like any other, so people couldn't see which of their plugins need to move.

The list marks deprecated plugins and prints each one's notice after the table, using only cached catalog data. Search tags them and prints the notices after its table, while its JSON output carries the deprecation as an optional field and prints no notice. The browser tags the entry and shows the notice in its details.

Test plan

  • The list shows a deprecated status, keeps the upgrade hint for a newer version, and prints the notice on stderr even for a plugin shown as an API mismatch
  • Search prints notices on stderr in table mode only, its JSON output includes the deprecation, and its name-only output is unchanged
  • The browser tags the entry and shows the notice in its details
  • Build, vet, and the plugin tests pass

Stacked on #376. Fixes #371

🤖 Generated with Claude Code

@0xmc
0xmc force-pushed the feat/370-deprecation-resolution branch from d035054 to 53a16a9 Compare November 17, 2026 19:08
The plugin list, search, and browser showed a deprecated plugin like
any other, so people could not see which of their plugins need to
move.

plugin list marks a deprecated plugin with a "deprecated" STATUS,
which takes precedence over "update" but not over an API mismatch
or missing version info, and prints each deprecated plugin's notice
to stderr after the table whatever its STATUS. A deprecated plugin
with a newer version still counts as an available update, so the
upgrade hint keeps printing. list reads only the cached catalog
indexes, so it stays offline; a catalog not fetched yet shows
nothing.

plugin search prefixes the description with "[deprecated]" and, in
table mode, prints each notice to stderr after the table. -o json
adds the catalog's deprecation as an optional "deprecated" field and
prints no notices; -o name is unchanged, so script output stays
parseable. plugin browse tags the entry and shows the notice in the
details pane.

Resolves: #371

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0xmc
0xmc marked this pull request as ready for review November 18, 2026 17:09
@0xmc
0xmc requested a review from a team as a code owner November 18, 2026 17:09
@0xmc
0xmc enabled auto-merge November 18, 2026 17:09
@0xmc

0xmc commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Both reviewers agreed on the reviewed feature commit fcf0088 (the head da0d073 adds only the merge from main).

pr-adversary: no findings; VERDICT merge. It ran: git diff 53a16a9...fcf0088 (stat and non-test files); gh pr view body; go build/vet/test ./internal/cmd/plugin/; gh pr checks 378; reads of deprecation.go, list.go, search.go, and the pluginstore catalog, index and manifest.

pr-conventions-reviewer: VERDICT merge. It ran: gh pr view; git diff/log 53a16a9..fcf0088; gh pr list for overlap; go build/vet/test; gofmt -l. Three nits were not applied: a docs paragraph reflow, reverting a gofmt-only comment alignment, and moving TestSearch_* to a search test file. Its concern that #379 would conflict was ruled invalid, because #379 is stacked on this PR and contains it.

Earlier fixes: the first pass at ac91150 found one warning (a deprecated plugin with a newer version lost the upgrade hint). It was fixed and re-reviewed with a tamper test. A later whole-branch review added search notices in table mode and list notices for ! and ? rows; those were squashed into fcf0088 and re-reviewed after tamper tests.

CI on da0d073: ci / Build and test passed and license/cla passed.

Auto-merge is enabled with the merge method (the ruleset allows merge commits only). The ruleset requires one approving review with code owner review and last-push approval, so the PR waits for a human approval. #379 is stacked on this PR.

@0xmc
0xmc merged commit ae55111 into main Nov 18, 2026
2 checks passed
@0xmc
0xmc deleted the feat/371-deprecation-listings branch November 18, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin listings don't show deprecation

2 participants