Repository navigation
Conversation
This was referenced Sep 20, 2026
This was referenced Sep 20, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
The Source Text browser accepted SQL routines/views but selected the null source adapter and failed while creating highlights. SQL definitions live in model entities rather than indexed files.
The optional
FmxSQLSourceTextAdapterparticipates in MooseIDE's existing adapter discovery. It displays routine/view source and translates AST source intervals relative to the displayed definition or query fragment. Invalid, unrelated and outside-fragment anchors return no highlight; unanchored definitions display as plain text. Original SQL and model relationships are unchanged.Packaging and dependencies
Adds optional
MooseIDE/MooseIDETestsgroups for a preinstalled Moose 13 image. Core stays usable in plain Pharo without UI classes. The ready-made Moose CI job loads the optional test group through.smalltalk.moose.ston; the plain Pharo job keeps the Core test configuration.Stacked PR: base is #25's source-anchor branch, keeping that implementation out of this diff. This change also pins Famix to
b0a762751dd06ebe46f98d016943613d28c18d82, the separately reviewed scalar-containment fix in deem0n/Famix#2. That traversal fix is required by Source Text highlighting of SQL views. The final release gate will consolidate dependency pins.Validation
4 tests passed, 0 failures/errors in an isolated Pharo 13 / Moose 13 image. They cover adapter discovery, plain source fallback, fragment offset translation, unrelated/invalid intervals, and opening the actual standard browser on routines and scalar-query views with exact displayed-text comparison.
git diff --checkpassed. The new CI job must pass before merge.Addresses #14. See
docs/mooseide-integration.mdfor loading and behavior. This is v3 development work, not a published release.