Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft combines four separate fixes for FAMIXNGSQL v3 qualification: #1 Name Cloud, #2 scalar containment navigation, #4 namespace hierarchy and #5 Fame metadata for specialized groups. Review and merge the individual PRs first. This branch contains their exact commits and no additional runtime adaptation.
The namespace fix retains its seven regression tests. Its dedicated workflow/configuration was removed in response to upstream moosetechnology#1150 review; the existing combined FAMIXNGSQL Moose CI runs those tests. The Fame fix is already merged upstream in moosetechnology#1149 and is preserved here because the fork base predates it.
Tracks deem0n/FAMIXNGSQL#24. deem0n/FAMIXNGSQL#32 pins the complete immutable dependency commit and runs SQL plus generic-tool regressions. The original two-fix matrix passed; updated combined CI runs are attached to the current head. No v3 release is authorized by this draft.
Final combined fork matrix is green at
a4c7ab04868fc924bb0ca470142c60d8576f6a17: https://github.com/deem0n/Famix/actions/runs/35537750108 (all eight Pharo 13/14 jobs). SQL integration also passed 244 Moose tests and 85 plain Pharo tests: https://github.com/deem0n/FAMIXNGSQL/actions/runs/35537847634.