Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application default providers query used
allClients, so a newly opened Butterfly map could show incoming clients on both sides. It now usesallProviders; the default clients query remains unchanged.The regression test builds a real client -> central -> provider invocation chain and checks the two default queries independently, avoiding a symmetric fixture that would conceal the bug.
Revalidated for this milestone in an isolated Pharo 13 / Moose 13 image: 50 passed, 2 skipped, 0 failures/errors across
MiApplicationTest,MiButterflyMapModelTestandMiButterflyMapBrowserTest.Addresses deem0n/FAMIXNGSQL#23. This is a fork-targeted review of existing commit c7d7e46, already proposed upstream in moosetechnology#1659. It does not create a duplicate upstream implementation. The v3 integration image must contain the fix before the issue is closed.
Updated CI evidence
Full fork CI test job passed: https://github.com/deem0n/MooseIDE/actions/runs/35536994921. Actions is now enabled and the fork-specific
MOOSE_PHARO_VERSIONSrepository variable supplies the Pharo 13 matrix; earlier notes about unavailable fork CI are superseded. Combined SQL qualification is tracked in deem0n/FAMIXNGSQL#32. Release acceptance stays open until reviews and final integrated checks.