Repository navigation
Escape conditional formatting expressions in worksheet XML - #643
Open
JimmyLiuJia wants to merge 1 commit into
Open
JimmyLiuJia wants to merge 1 commit into
JimmyLiuJia wants to merge 1 commit into
Conversation
rzymek
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563.
ConditionalFormattingExpressionRulewrote formulas directly into worksheet XML. Expressions containing<or&could make the workbook invalid. Serialize the formula with the existingWriter.appendEscapedmethod, preserving the caller's expression.The regression writes
IF(A1<5,A1&"x",""), reopens the workbook with Apache POI, and checks that the formula round-trips unchanged.Validation:
mvn -pl fastexcel-writer testpassed (113 tests, 0 failures, 0 errors) on Java 17. The focusedPoiCompatibilityTestpassed all 26 tests.AI assistance was used to investigate, implement, test, and draft this PR.