Skip to content

Escape conditional formatting expressions in worksheet XML #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JimmyLiuJia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape conditional formatting expressions in worksheet XML #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastexcel-writer/src/main/java/org/dhatim/fastexcel/ConditionalFormattingExpressionRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public ConditionalFormattingExpressionRule(String expression, boolean stopIfTrue
public void write(Writer w) throws IOException {
w
.append("<cfRule type=\"").append(TYPE).append("\" priority=\"").append(priority).append("\" stopIfTrue=\"").append(stopIfTrue ? "1" : "0").append("\" dxfId=\"").append(dxfId).append("\">")
.append("<formula>").append(expression).append("</formula>")
.append("<formula>").appendEscaped(expression).append("</formula>")
.append("</cfRule>");
}
}
15 changes: 15 additions & 0 deletions fastexcel-writer/src/test/java/org/dhatim/fastexcel/PoiCompatibilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,21 @@ void hasValidCellConditionalFormatting() throws Exception {
assertTrue(cellRange.formatAsString().equals("A1"));
}

@Test
void conditionalFormattingExpressionIsEscaped() throws Exception {
String formula = "IF(A1<5,A1&\"x\",\"\")";
byte[] data = writeWorkbook(wb -> {
Worksheet ws = wb.newWorksheet("Worksheet 1");
ws.style(0, 0).fillColor("FF8800").set(new ConditionalFormattingExpressionRule(formula, true));
});

try (XSSFWorkbook workbook = new XSSFWorkbook(new ByteArrayInputStream(data))) {
XSSFConditionalFormattingRule rule = workbook.getSheetAt(0)
.getSheetConditionalFormatting().getConditionalFormattingAt(0).getRule(0);
assertEquals(formula, rule.getFormula1());
}
}

@Test
void hasValidRangeConditionalFormatting() throws Exception {
byte[] data = writeWorkbook(wb -> {
Expand Down