Conversation
…uilder::lists() (task 2.5d) Completes the fork side of the pluck/lists pipeline. Query\Builder and Eloquent\Builder pluck($column, $key = null) now return the list (old lists() body, an array); the scalar path lives in value() (added in 2.5a). lists() is removed from both builders. Internal callers rewired: Query\Builder::implode(), DatabaseMigrationRepository::getRan(), BelongsToMany (getRelatedIds/getCurrentIds) now use pluck(). Support\Collection::lists() kept (Collection callers convert in app 2.5c). Fork suite green: 1647 tests / 3659 assertions. Stacked on migration/2.5-fork-stack (= 4.2.95 + 2.5a value() + 2.5e SoftDeletes); this branch is what the app pins for task 2.5c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #64 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork side of the pluck/lists pipeline (task 2.5d). Bagian L42x→L13.
Base =
migration/2.5-fork-stack(=pre-release/4.2.95+ 2.5avalue()[#62] + 2.5e SoftDeletes [#61]), jadi diff PR ini cuma flip pluck-nya. Branch ini yang di-consume app buat task 2.5c (#5830) via composer. Reconciliation ke master ikut alur pre-release (2.5a #62 + 2.5e #61 + ini) — sejalur dengan 2.8/4.2.95.Perubahan
Query\Builder+Eloquent\Builder:pluck($column, $key = null)sekarang return list (array) (bodylists()lama); scalar path pindah kevalue()(2.5a).Builder::lists()dihapus dari kedua builder. Caller internal di-rewire kepluck():Query\Builder::implode(),DatabaseMigrationRepository::getRan(),BelongsToMany(getRelatedIds/getCurrentIds).Support\Collection::lists()dipertahankan (Collection caller di-handle app 2.5c dgn->all(); cleanup nanti).Verifikasi
value()).🤖 Generated with Claude Code