Conversation
agissept
force-pushed
the
pre-release/4.2.96
branch
from
September 17, 2026 13:12
02e8c9f to
5fba8d0
Compare
…ditive) First, non-breaking step of the pluck/lists pipeline. value($column) is a copy of today's scalar pluck() body on both Query\Builder and Eloquent\Builder — value() === pluck() for scalars right now. Purely additive: no call-site changes behavior, pluck() untouched. Unblocks app 2.5b (->pluck()->->value()) WITHOUT flipping pluck semantics, so the repos never flip in the same instant. Tests: value() returns the scalar and equals pluck() (Query + Eloquent). Database suite 516 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ace→Scope, Model to L13 contracts (task 2.5e)
Safe, type-caught slice of task 2.5 (Database). No alias — old FQCNs fatal
so the app is forced to conform (task 2.5f, lockstep).
- SoftDeletingTrait → SoftDeletes; boot hook bootSoftDeletingTrait() →
bootSoftDeletes() (MUST match the new trait basename or Eloquent silently
stops registering SoftDeletingScope → soft-deleted rows leak). Proven by
DatabaseEloquentBuilderTest:486 (fails when the hook name is wrong).
- ScopeInterface → Scope; SoftDeletingScope + Model typehints updated.
- Model implements Illuminate\Contracts\Support\{Arrayable,Jsonable} (were
Illuminate\Support\Contracts\{ArrayableInterface,JsonableInterface}); the 2
Model instanceof checks migrated to Arrayable. BC-safe: old contracts extend
the new ones, so instanceof Arrayable is strictly wider.
Does NOT touch lists()/pluck() — that dangerous semantic swap is the separate
2.5a–d pipeline. Fork suites green (Database 513, Support/Http/View 199).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…uilder::lists() (task 2.5d) Completes the fork side of the pluck/lists pipeline. Query\Builder and Eloquent\Builder pluck($column, $key = null) now return the list (old lists() body, an array); the scalar path lives in value() (added in 2.5a). lists() is removed from both builders. Internal callers rewired: Query\Builder::implode(), DatabaseMigrationRepository::getRan(), BelongsToMany (getRelatedIds/getCurrentIds) now use pluck(). Support\Collection::lists() kept (Collection callers convert in app 2.5c). Fork suite green: 1647 tests / 3659 assertions. Stacked on migration/2.5-fork-stack (= 4.2.95 + 2.5a value() + 2.5e SoftDeletes); this branch is what the app pins for task 2.5c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agissept
force-pushed
the
pre-release/4.2.96
branch
from
September 17, 2026 13:17
5fba8d0 to
8721e1d
Compare
This was referenced Sep 17, 2026
agissept
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR untuk l42x 4.2.96 (tag
4.2.96= tip branch ini). Fork-half dari deploy task 2.5, sepola #59 (pre-release → master). Menggantikan task-PR #61/#62/#63 (di-close).Isi — task 2.5 Database ONLY (rebased & bersih)
Builder::value()additive (scalar getter).SoftDeletingTrait→SoftDeletes,ScopeInterface→Scope, Model→L13 contracts (Arrayable/Jsonable).Builder::pluck()jadi list-returning,Builder::lists()dihapus (caller internal →pluck()).Diff: +106/−106, 13 file, murni
src/Illuminate/Database/*. Routing engine (2.8) udah di master (rebase drop otomatis); pagination getter bridge (2.15) di-drop (app pakai getter L13, nggak butuh).Konsumsi app
App pin
"laravel/framework": "4.2.96"di #5830 (dicoding). Deploy = matched pair: PR ini → master + #5830 → app master, 1× canary.Verifikasi
🤖 Generated with Claude Code