You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closes#55, #82
In this PR, I fixed spelling and CHANGLOG formatting issues. For index_ext.cpp, I left one wrap indexing ORTHOROMBIC for backend-compatible alias in case someone who uses misspelling one. But for next main release, we should remove this.
Please make an issue to remove the misspelled wrap in a future release. Ideally we would deprecate it, so if someone uses the misspelling it works but generates a warning message that this will be removed in the future.
Please could you also make sure that the Issues will close automatically when this merges, I don't think I saw that in the top comment.
Please make an issue to remove the misspelled wrap in a future release. Ideally we would deprecate it, so if someone uses the misspelling it works but generates a warning message that this will be removed in the future.
Please could you also make sure that the Issues will close automatically when this merges, I don't think I saw that in the top comment.
I will make this shortly, the reason we fail is that in libobjcryst we did not point the fixed version to the repo so it still using the old typo version. so the sequence we should follow is:
Update the libobjcryst pointing to the fixed spelling one, then we release it.
Bump the dependency version of libobjcryst for pyobjcryst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55, #82
In this PR, I fixed spelling and CHANGLOG formatting issues. For
index_ext.cpp, I left one wrap indexingORTHOROMBICfor backend-compatible alias in case someone who uses misspelling one. But for next main release, we should remove this.