Skip to content

fix: fix spelling and changelog, pre-commit auto-fix - #97

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
stevenhua0320:fix-everything
Aug 9, 2026
Merged

fix: fix spelling and changelog, pre-commit auto-fix#97
sbillinge merged 4 commits into
diffpy:mainfrom
stevenhua0320:fix-everything

Conversation

@stevenhua0320

@stevenhua0320 stevenhua0320 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Closes #55, #82
In this PR, I fixed spelling and CHANGLOG formatting issues. For index_ext.cpp, I left one wrap indexing ORTHOROMBIC for backend-compatible alias in case someone who uses misspelling one. But for next main release, we should remove this.

@sbillinge

Copy link
Copy Markdown
Contributor

@stevenhua0320 this seems to be failing tests.

Please make an issue to remove the misspelled wrap in a future release. Ideally we would deprecate it, so if someone uses the misspelling it works but generates a warning message that this will be removed in the future.

Please could you also make sure that the Issues will close automatically when this merges, I don't think I saw that in the top comment.

@stevenhua0320

stevenhua0320 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@stevenhua0320 this seems to be failing tests.

Please make an issue to remove the misspelled wrap in a future release. Ideally we would deprecate it, so if someone uses the misspelling it works but generates a warning message that this will be removed in the future.

Please could you also make sure that the Issues will close automatically when this merges, I don't think I saw that in the top comment.

I will make this shortly, the reason we fail is that in libobjcryst we did not point the fixed version to the repo so it still using the old typo version. so the sequence we should follow is:

  1. Update the libobjcryst pointing to the fixed spelling one, then we release it.
  2. Bump the dependency version of libobjcryst for pyobjcryst
  3. rerun this PR.

@sbillinge
sbillinge merged commit ca0b6ff into diffpy:main Aug 9, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct "ORTHOROMBIC" with backward compatibility

2 participants