Repository navigation
Fix Unicode CLI crash, Codex round counting and control timing - #331
Merged
Merged
Conversation
- Write UTF-8 when CLI output is redirected on a legacy code page, so Unicode task IDs no longer raise UnicodeEncodeError mid-command. - Reject an interleaved control captured before the session was frozen. - Count pairs that passed correctness checks in aggregate report headlines. - Record one Codex model span per model round instead of splitting a message and its tool call into two model calls. - Document a second Codex run that exercised the aggregate decision, interleaved control and repetition_detour finding together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AgentLoop replay self-testThis required repository check evaluates generated synthetic demo traces. It tests the replay and CI machinery; it does not show that this PR improves application performance. AgentLoop CI Report
Performance Gates
Trace inputsThis comparison includes synthetic data. It does not establish application performance gains from a pull request.
Metric Impact
Top Findings
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs found by end-to-end testing
检查-✓raisedUnicodeEncodeErrorpartway throughimprove capture. The command's real result was replaced by a traceback. A root Typer callback now reconfigures redirected stdout and stderr to UTF-8 (errors="replace"). Interactive consoles are already UTF-8 and are left unchanged. The new regression test forcesPYTHONIOENCODING=cp1252, so it also runs on Linux CI. It fails without the fix and passes with it.repetition_detourreports ("2 more model steps" when it was 1). The runner now records one span per model round: from the turn start, or the end of the last running tool, until the next tool starts or the final message. Items within a round are listed incodex_items.finishalready required the candidate capture to come after the frozen session, but not the control. It now checks both.End-to-end Codex validation (24 interleaved runs plus a 12-run baseline)
Exercised the aggregate decision, the interleaved control,
repetition_detourand the fixed runner together, with 4 repetitions per task:docs/CODEX.md.Other checks
test_codex_exec_runner.py10 passed,test_improvement.pypassing.--decision, failing control runner.npm auditare clean.mkdocs build --strictand pre-commit are clean.🤖 Generated with Claude Code