Repository navigation
Fix review findings in repetition detours and the Codex runner - #332
Merged
Merged
Conversation
- Compare only completed attempts between repetitions, so a failed or interrupted attempt's partial trace cannot distort the typical one. - State observed and typical step counts instead of fractional differences, and keep diagnosis ranking counts in step with findings. - Profile each trace once instead of rescanning every repetition. - Close a Codex model round when a tool arrives only on completion and measure rounds from their own start. - Accept per-pair in improve start and name that spelling in errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AgentLoop replay self-testThis required repository check evaluates generated synthetic demo traces. It tests the replay and CI machinery; it does not show that this PR improves application performance. AgentLoop CI Report
Performance Gates
Trace inputsThis comparison includes synthetic data. It does not establish application performance gains from a pull request.
Metric Impact
Top Findings
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from a high-effort code review of
v0.2.2..main.Fixed
repetition_detourused every attempt that left a trace, so a failed or interrupted attempt's partial trace could shift the typical repetition, or be flagged itself.startandfinish(for controls) now pass only completed attempts.ranking.ready_to_test_countwas not recomputed after detour findings were merged. It now is.--decisionspelling. An invalid value namedper_pairalthough the CLI documentsper-pair.startnow accepts both, and the error namesper-pair.Skipped
In aggregate mode, slower pairs keep
gates_passed: falsein their intervention records. Each record honestly measures its own pair. The overall verdict lives in the report'sdecision.Tests
test_repetitions.py,test_codex_exec_runner.pyandtest_improvement.py: 54 passed.🤖 Generated with Claude Code