Repository navigation
Add a runner wall-time gate to guided comparisons - #337
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AgentLoop replay self-testThis required repository check evaluates generated synthetic demo traces. It tests the replay and CI machinery; it does not show that this PR improves application performance. AgentLoop CI Report
Performance Gates
Trace inputsThis comparison includes synthetic data. It does not establish application performance gains from a pull request.
Metric Impact
Top Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a retained offline retrieval comparison, the candidate passed the trace-latency gate even though the median paired runner time rose by 24 ms. Developers need an optional guard for this measurement when total process time matters to their workload.
Changes
improve start --max-runner-regression-ms Nfreezes the allowed wall-time increase for each candidate pair. The comparison uses the interleaved control when supplied.Validation
.venv/Scripts/python.exe -m pytest tests/test_improvement.py tests/test_guided_verifier.py -q --basetemp D:/agentloop/runs/runner-regression-focused --tb=short— 41 passed..venv/Scripts/python.exe runs/bugfix_quality_checks.py— all applicable hooks passed.uv build --out-dir runs/runner-regression-dist --quietand Twine checks passed for the wheel and sdist.runs/coding-agent-local-pilot/venv/Scripts/python.exe -I scripts/smoke_installed_wheel.py --expected-version 0.2.3passed from the locally built wheel.venv/Scripts/python.exe -I pilot.pyfromD:/agentloop/runs/coding-agent-local-pilotused the locally built wheel and separate standard-library application tests. The equivalent refactor passed all four paired attempts with one scan instead of three per run. Deliberate cleanup delay made the median paired runner time 1.22 seconds slower while the trace was faster, and all four runner gates rejected it. The broken refactor passed the built-in output-shape check and failed all four application verifications. Reports and original checksums are retained locally.d2f92e39bf0bbd039107f6d3da79e0f2a723d33abefore squash merge. Both CI and smoke validation use owned offline workloads..venv/Scripts/python.exe -m pytest -q --basetemp D:/agentloop/runs/runner-regression-full --tb=short— 2,822 passed, 109 skipped.Compatibility
The gate is opt-in. Existing sessions and reports remain readable, and existing ungated decisions continue to use their frozen checks. For a gated comparison with an older baseline, a fresh interleaved control supplies the required monotonic times.
Substantial implementation and validation assistance was provided by Codex.