Repository navigation
Start a fresh proxy in proxy smoke tests - #1302
Merged
Merged
Conversation
proxy-signals and proxy-python share the smoke-test-proxy fixture dir and run in parallel, so proxy run could attach to the other file's session while it was shutting down and fail with ECONNREFUSED.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed proxy-session isolation in both smoke-test files and the CLI's --new behavior.
- Python TLS tests: Both installed CLI and compiled binary runs force a fresh proxy session.
- Signal tests: All signal-test runs force a fresh session, avoiding attachment to another test's shutting-down proxy.
gpt-6.1-sol ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ubuntu smoke test failure on the release PR (#1264). This was meant to land with #1301 but was pushed after it merged.
proxy-signalsandproxy-pythonshare thesmoke-test-proxyfixture dir and vitest runs them in parallel, soproxy runcould attach to the other file's proxy session while it was shutting down and fail withECONNREFUSED("Proxy session ... is not responding"). Both now pass--new.